Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project - Diego Fernández #77

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Diego23232002
Copy link

Project - Diego Fernandez

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for mucss-dataviz ready!

Name Link
🔨 Latest commit f5fbdec
🔍 Latest deploy log https://app.netlify.com/sites/mucss-dataviz/deploys/676d2f0e33f4cf00083e4fb5
😎 Deploy Preview https://deploy-preview-77--mucss-dataviz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Diego23232002 Diego23232002 marked this pull request as ready for review December 1, 2024 17:30
@Enchufa2 Enchufa2 changed the title initial version Project - Diego Fernández Jan 9, 2025
Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some comments below.

---
title: "Serena Williams Career"
description: |
it shows the ranking of the famous tennis player.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start in uppercase.

Below is the original chart for reference:


![Original Plot](../100452420/original_plot.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set it as "external" as e.g. David does here.

Comment on lines +46 to +49
wta90s <- as_tibble(read.csv("C:/Users/diegu/Downloads/wta_rankings_90s.csv"))
wta00s <- as_tibble(read.csv("C:/Users/diegu/Downloads/wta_rankings_00s.csv"))
wta10s <- as_tibble(read.csv("C:/Users/diegu/Downloads/wta_rankings_10s.csv"))
wta20s <- as_tibble(read.csv("C:/Users/diegu/Downloads/wta_rankings_20s.csv"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh, there's an excel file but you invoke these CSVs. Then please remove the excel file and add these CSVs to the PR close to this Rmd. Then, call just read.csv("wta_rankings_90s.csv") etc. That is, in general, add all files you use to the PR and load them just with the relative path, removing any reference to paths in your on computer. ;-)


library(patchwork)
library(readxl)
serena_slams <- read_xlsx("C:/Users/diegu/Desktop/Master in Computational Social Sciences/data visualization/replicate plot/dataviz/_projects/2024/100452420/SerenaWilliams_slams_data.xlsx")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you use the excel file here. Then, remove the path. The name of the file is enough, because it's right here. The same with the CSVs.

Finally, the arrows, dotted lines, and source were added to the chart. Both the arrows and dotted lines were created using the annotate function. The source is placed at the bottom of the chart, as in the original. Although I did not obtain the data directly from the WTA, I aimed to replicate the original plot as closely as possible.


```{r, layout = "1-body-outset", fig.width= 10, fig.height= 3.9}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add preview = TRUE so that this image is shown in the list of projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants